Conversation
…s true When noSubtitle is set to true, the subtitle should be excluded from the computed aria-label to prevent long panel announcements from interrupting child item TTS during rapid navigation. This fixes an issue where webOS Audio Guidance would prepend the panel's aria-label (title + subtitle) to every focused child element's TTS text, causing the actual item content (e.g., Wi-Fi SSID names) to be cut off during rapid 4-way navigation. Related: WEBOSEVENT-1887 Co-Authored-By: Claude Code <noreply@anthropic.com>
- Updated existing test to expect trimmed aria-label - Added test for noSubtitle=true excluding subtitle from aria-label - Added test for noSubtitle=false including subtitle in aria-label Related: WEBOSEVENT-1887 Co-Authored-By: Claude Code <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #437 +/- ##
========================================
Coverage 83.24% 83.24%
========================================
Files 155 155
Lines 7824 7825 +1
Branches 2413 2414 +1
========================================
+ Hits 6513 6514 +1
Misses 1019 1019
Partials 292 292 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Fixes an issue where WizardPanels' panel-level
aria-label(title + subtitle) interrupts child item TTS during rapid navigation on webOS devices with Audio Guidance enabled.Resolution
When
noSubtitleprop is set totrue, the subtitle is now excluded from the computedaria-labelin addition to hiding it from the UI.Problem Detail:
When navigating quickly through items in a WizardPanels (e.g., Wi-Fi network list), the webOS Audio Guidance system prepends the panel's
aria-labelto every focused child element's TTS text. With{clear: true}on each focus event, the long panel subtitle is spoken repeatedly, cutting off the actual item content (e.g., SSID names) before it can be heard.TTS Log Example:
Code Change:
computed['aria-label']inWizardPanels.jsto checknoSubtitlepropnoSubtitleis true, subtitle is excluded from aria-label.trim()to handle empty subtitle caseAdditional Considerations
Links
NXT-20313
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung.hong (taeyoung.hong@lge.com)