Conversation
wjt
left a comment
There was a problem hiding this comment.
Rather than (fixes #1745) in the title of the PR, it needs to be in the description of the PR on a line of its own:
Fixes #1745
As i noted in the issue:
If it's already an MP3 there is no upside to converting it back to WAV - it will be lossily compressed a second time when exporting the game.
There is an annoying low frequency hum/buzz in that clip.
I think the melody is a little too long, and to me it sounds a bit too sinister for a positive effect!
There was a problem hiding this comment.
I don't think this is a UI sound effect.
I think you could put it directly in assets/first_party/sounds, or better, in a new folder assets/first_party/sounds/collectibles/ mirroring the assets/third_party/sounds/collectibles/ folder.
|
Pull request updated |
There was a problem hiding this comment.
We generally try to avoid filenames with spaces in them. Please could you rename this to health_regained.wav?
There was a problem hiding this comment.
I've already renamed the WAV file
|
Play this branch at https://play.threadbare.game/branches/FinalRed/fix-health-audio/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Fixes #1745
Added health regained sound effect generated with Strudel:
The audio file was created by me and is contributed under the project's license :D.