Make Eternal Loom animation dynamic based on threads collected by the player by Un-player0 · Pull Request #2864 · endlessm/threadbare

Un-player0 · 2026-09-09T03:05:10Z

Adds an script that replaces loom_offering_animation.

This new version dynamically shows the number of threads the player collected in the current quest with it's corresponding color

Uses a Path2D to move the threads

Resolves: #1861

…-1030 merging changes from endless main branch

github-actions · 2026-09-09T03:09:45Z

Test build no longer available.

Un-player0 · 2026-09-09T03:11:15Z

Short video fo how it should look

loom_animation_test.mp4

manuq

This is impressive work, already. Thanks! Here are some requests and suggestions.

The Path2D you have is made of straight lines:

I think it would be nice to make it a circle. The curve of a Path2D is a Bezier curve so this is possible:

However, if following this advice and the one for sampling the points, you will have to add a PathFollow2D node and tween the progress, for positioning each thread.

manuq · 2026-09-09T16:37:38Z

+const WORLD_MEMORY = preload("uid://5wscjc8yqqts")
+const WORLD_SPIRIT = preload("uid://cepg1o3ihp055")
+
+@export var _play_animation: bool = false:


Nice, I like how you made it very easy to test the animation from the editor with this. But please check the warning on this line. It says that the variable is not used. There is a better way: Adding an @export_tool_button, which adds a button to the Inspector. There are a number of examples in this repository already. For example, the Randomize button in townie.tscn

manuq · 2026-09-09T16:53:57Z

+	# Time between each animation_point
+	var timer: float = animation_time / (animation_points.size() * 2.8)
+	# Separation between threads
+	var separator: int = animation_points.size() / floor(thread_list.size())


Since #1234 was merged, zero threads is a possible number. And the script will raise a zero division error. So you may want to skip this animation entirely for zero threads.

manuq · 2026-09-09T16:54:45Z

+	var arr: Array[InventoryItem]
+	for i in range(debug_thread_count):
+		var temp_item := InventoryItem.new()
+		temp_item.type = InventoryItem.ItemType.MEMORY


It would be nice to pick the item type randomly for better debugging.

manuq · 2026-09-09T17:22:04Z

+
+
+func _loom_animation_play(thread_list: Array[InventoryItem]) -> void:
+	var animation_points := animation_path.curve.get_baked_points()


Since you made it so easy to test (thanks!) I tried with 20 threads and saw a single one being animated. I see now that this works with up to 12 threads: because the curve of your Path2D node has 12 points.

Making it work with more than 12 threads is not necessary, but I think there is a better way: you can pick points from the sampled curve:

var animation_points: Array[Vector2] var curve_length := animation_path.curve.get_baked_length() var separation := curve_length / thread_list.size() for i in thread_list.size(): var offset := separation * i var point := animation_path.curve.sample_baked(offset) animation_points.append(point)

Then it will work with 20+ threads!

Grabacion.de.pantalla.desde.2026-09-09.14-20-22.mp4

manuq · 2026-09-09T17:26:05Z

+		match thread.type:
+			InventoryItem.ItemType.MEMORY:
+				sprite.texture = WORLD_MEMORY
+			InventoryItem.ItemType.IMAGINATION:
+				sprite.texture = WORLD_IMAGINATION
+			InventoryItem.ItemType.SPIRIT:
+				sprite.texture = WORLD_SPIRIT
+			_:
+				sprite.texture = WORLD_SPIRIT


Not needed! There is a helper function already in inventory_item. You can just use:

sprite.texture = thread.get_world_texture()

Un-player0 · 2026-09-12T20:57:51Z

However, if following this advice and the one for sampling the points, you will have to add a PathFollow2D node and tween the progress, for positioning each thread.

Took this into consideration and used the PathFollow2D to move every thread along the circumference

Should look like this

loom_test_2.mp4

manuq

This is impressive! Great work! Approving, please consider my suggestions. They are tiny details, but overal the new dynamic animation is fantastic.

manuq · 2026-09-14T18:57:14Z

+	var arr: Array[InventoryItem]
+	for i in range(debug_thread_count):
+		var temp_item := InventoryItem.new()
+		var item_types := InventoryItem.ItemType.values()
+		item_types.remove_at(3)  ## Remove the 'None' Item Type
+		temp_item.type = item_types.pick_random()
+		arr.append(temp_item)
+	_loom_animation_play(arr)


Is better to use descriptive variable names. Also item types will be the same on each for loop, so it should be outside. And the way you are removing ItemType.NONE is by index, which will fail as soon as that enum changes, so is not the best. I suggest for now using InventoryItem.COLORS_PER_TYPE.keys() or an explicit array. In the future we can consider adding a utility function.

Suggested change

var arr: Array[InventoryItem]

for i in range(debug_thread_count):

var temp_item := InventoryItem.new()

var item_types := InventoryItem.ItemType.values()

item_types.remove_at(3) ## Remove the 'None' Item Type

temp_item.type = item_types.pick_random()

arr.append(temp_item)

_loom_animation_play(arr)

var debug_items: Array[InventoryItem]

# TODO: InventoryItem needs a utility function to obtain all types except NONE.

var item_types := InventoryItem.COLORS_PER_TYPE.keys()

for i in range(debug_thread_count):

var item := InventoryItem.new()

item.type = item_types.pick_random()

debug_items.append(item)

_loom_animation_play(debug_items)

manuq · 2026-09-14T19:13:42Z

+
+	var counter: int = 0
+	for thread in thread_list:
+		var path_follow := PathFollow2D.new()


Excellent! Yes I see you need one PathFollow2D per thread.

manuq · 2026-09-14T19:14:43Z

+
+		animation_path.add_child(path_follow)
+
+		## Starting point for each thread


This is not a documentation comment, so it should have a single #.

Suggested change

## Starting point for each thread

# Starting point for each thread

manuq · 2026-09-14T19:15:02Z

+		## Starting point for each thread
+		path_follow.progress_ratio = counter * separation
+
+		## Time variation between threads


Suggested change

## Time variation between threads

# Time variation between threads

manuq · 2026-09-14T19:15:16Z

+
+		var tween := path_follow.create_tween()
+
+		## The first thread is the last to end


Suggested change

## The first thread is the last to end

# The first thread is the last to end

manuq · 2026-09-14T19:16:24Z

+		counter = counter + 1
+
+
+## Remove thread once animation finishes


Suggested change

## Remove thread once animation finishes

# Remove thread once animation finishes

manuq · 2026-09-14T19:18:38Z

+		tween.parallel().tween_property(sprite, "modulate", Color(0, 0, 0, 0), 0.5)
+		tween.parallel().tween_property(sprite, "scale", Vector2(3, 3), 0.5)
+		tween.tween_callback(_thread_free.bind(sprite))
+		counter = counter + 1


We tend to have this shorter version everywhere else:

Suggested change

counter = counter + 1

counter += 1

manuq · 2026-09-14T19:21:16Z

+		tween.tween_property(sprite, "scale", Vector2(1, 1), 0.5)
+		## Loop around
+		tween.parallel().tween_property(
+			path_follow, "progress_ratio", 2.0, loop_time - time_variation * counter


I see, so when counter is zero this property is tweened by loop_time seconds. That's why the first thread in the for loop is the one emitting animation_finished.

manuq · 2026-09-14T19:21:53Z

-position = Vector2(0, 39)
+position = Vector2(-1, 39)


This change is unrelated, please revert it.

manuq · 2026-09-14T19:22:47Z

-position = Vector2(0, 135)
+position = Vector2(0, 85)
+script = ExtResource("6_rle0d")
+debug_thread_count = 7


Maybe commit the tscn file with the default amount for debug_thread_count.

Un-player0 and others added 14 commits August 25, 2026 19:03

implemented uisfx_player

844d4a5

Moved sound files to first_party

79bf0dc

created multiple players

dff43b4

updated code to fit new players

9a21a52

Merge branch 'endlessm:main' into main

be91aec

random pitch for sliders and buttons

de4f0a4

Merge branch 'main' of https://github.com/Un-player0/threadbare-issue…

02097c9

…-1030 merging changes from endless main branch

audiostreams accessed by their unique names

d4b1c33

Merge branch 'endlessm:main' into main

a7ccf9f

Merge branch 'endlessm:main' into main

eb0371b

Eternal Loom new animation

3409e38

small update

6998727

Merge branch 'endlessm:main' into main

c6aa7e9

formatting

d363067

Un-player0 requested a review from a team as a code owner September 9, 2026 03:05

formatting

507448b

manuq requested changes Sep 9, 2026

View reviewed changes

Un-player0 added 5 commits September 9, 2026 21:54

small improvements

e622078

small improvements

afc0e1b

randomness and curve length

d961f24

new animation PathFollow2D

b549616

small fix

ab60cc7

manuq approved these changes Sep 14, 2026

View reviewed changes

Suggestions and small improvements

fd9f674

manuq approved these changes Sep 14, 2026

View reviewed changes

manuq merged commit 77c7630 into endlessm:main Sep 14, 2026
7 checks passed



		func _loom_animation_play(thread_list: Array[InventoryItem]) -> void:
		var animation_points := animation_path.curve.get_baked_points()


		animation_path.add_child(path_follow)

		## Starting point for each thread

	## Starting point for each thread
	# Starting point for each thread

	## Time variation between threads
	# Time variation between threads


		var tween := path_follow.create_tween()

		## The first thread is the last to end

	## The first thread is the last to end
	# The first thread is the last to end

		counter = counter + 1


		## Remove thread once animation finishes

	## Remove thread once animation finishes
	# Remove thread once animation finishes

Uh oh!

Conversation

Un-player0 commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Un-player0 commented Sep 9, 2026

Uh oh!

manuq left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Un-player0 commented Sep 12, 2026

Uh oh!

manuq left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Un-player0 commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

manuq left a comment •

edited

Loading