EPMDEDP-17289: fix: Count terminating CDPipelines as usage in the deletion webhooks - #317
Merged
Conversation
…etion webhooks
A CDPipeline blocks Codebase and CodebaseBranch deletion for as long as the
object exists, terminating included. The previous DeletionTimestamp filter
opened a window during pipeline teardown: the Codebase delete was admitted,
the owner-reference cascade removed the CodebaseImageStreams, and the
remaining Stage finalizers, which read those streams to strip environment
labels serially last-to-first, wedged the Stage and the CDPipeline in
Terminating forever.
Denials now name the terminating blocker ("being deleted") and advise
waiting for the teardown to finish instead of removing the reference.
Terminating Stages stay out of autotest-gate usage: stage teardown never
reads the autotest codebase.
Signed-off-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
Collaborator
Pipeline
|
| Status | Task | Duration |
|---|---|---|
| ✓ Passed | github-set-pending-status | 6s |
| ✓ Passed | fetch-repository | 18s |
| ✓ Passed | init-values | 7s |
| ✓ Passed | get-cache | 2m5s |
| ✓ Passed | commit-validate | 6s |
| ✓ Passed | dockerfile-lint | 7s |
| ✓ Passed | helm-lint | 7s |
| ✓ Passed | helm-docs | 13s |
| ✓ Passed | build | 49s |
| ✓ Passed | sonar | 18s |
| ✓ Passed | save-cache | 2m11s |
| ✓ Passed | buildkit-build | 1m15s |
| ✓ Passed | github-report-pipeline-status | 7s |
Pushing new commits re-runs this pipeline automatically.
To re-run it without new commits, comment/recheck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CDPipeline blocks Codebase and CodebaseBranch deletion for as long as the object exists, terminating included. The previous DeletionTimestamp filter opened a window during pipeline teardown: the Codebase delete was admitted, the owner-reference cascade removed the CodebaseImageStreams, and the remaining Stage finalizers, which read those streams to strip environment labels serially last-to-first, wedged the Stage and the CDPipeline in Terminating forever.
Denials now name the terminating blocker ("being deleted") and advise waiting for the teardown to finish instead of removing the reference. Terminating Stages stay out of autotest-gate usage: stage teardown never reads the autotest codebase.