Skip to content

Make the banner check run in CI and match the current card - #8

Merged
cezaraugusto merged 1 commit into
mainfrom
fix/banner-check-runs-in-ci
Sep 16, 2026
Merged

cezaraugusto merged 1 commit into
mainfrom
fix/banner-check-runs-in-ci

Conversation

@cezaraugusto

Copy link
Copy Markdown
Member

test:banner never ran in CI. build-and-lint restored node_modules but not the Playwright browser cache, so the script found no Chromium, printed a skip and exited 0 on every run

it also could not pass anywhere it did run. since Extension.js 4.1.0 the dev card keeps three rows and Profile ranks above Extension ID, so the line the check waited for is never printed. the skip hid that

the check now reads extensionId from ready.json and requires the exact id Chromium derives from the fixture manifest key, which proves the browser loaded this manifest. it waits for the real Browser Chromium card row, matched case-sensitively, because the old pattern was also satisfied by the echoed --browser chromium argument. dev runs with EXTENSION_HEADLESS=1 so no display is needed and no window steals focus

a missing Chromium now fails the step under CI and skips with an install hint locally. build-and-lint restores the Playwright cache with the same key dev-reload-chromium uses

locally the check passes in about 8s (it timed out at 96s before), and fails as expected with a wrong expected id and with a missing binary under CI=true

@cezaraugusto
cezaraugusto merged commit 2aa4dcb into main Sep 16, 2026
34 checks passed
@cezaraugusto
cezaraugusto deleted the fix/banner-check-runs-in-ci branch September 16, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant