Make the banner check run in CI and match the current card - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test:bannernever ran in CI.build-and-lintrestorednode_modulesbut not the Playwright browser cache, so the script found no Chromium, printed a skip and exited 0 on every runit also could not pass anywhere it did run. since Extension.js 4.1.0 the dev card keeps three rows and Profile ranks above Extension ID, so the line the check waited for is never printed. the skip hid that
the check now reads
extensionIdfromready.jsonand requires the exact id Chromium derives from the fixture manifest key, which proves the browser loaded this manifest. it waits for the real Browser Chromium card row, matched case-sensitively, because the old pattern was also satisfied by the echoed--browser chromiumargument. dev runs withEXTENSION_HEADLESS=1so no display is needed and no window steals focusa missing Chromium now fails the step under CI and skips with an install hint locally.
build-and-lintrestores the Playwright cache with the same keydev-reload-chromiumuseslocally the check passes in about 8s (it timed out at 96s before), and fails as expected with a wrong expected id and with a missing binary under
CI=true