Handle parser errors without crashing - #334
Open
PNHD wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40. Related to #253.
Parser exceptions currently escape from the stdout/stderr stream data callbacks, so invalid parsed output can crash the Node process instead of reaching
.end()/PythonShell.run().This keeps parser failures on the library's existing completion/error surface while preserving EventEmitter semantics:
emit(), so exceptions thrown by usermessage/stderrlisteners still propagate normally instead of being misclassified as parser failuresPythonShellErrorcompletion pathpythonError,.end(), andPythonShell.run()Regression coverage includes invalid JSON, custom stderr-parser failures, listener exceptions, and parser-vs-process error precedence.
Relationship to #326
#326 addresses the same JSON parse-failure family by adding a public
parseErrorevent/class. This PR keeps the existing completion/error surface instead, also handles custom stderr-parser failures, and keeps EventEmitter listener exceptions outside the parser catch path. I am happy to defer to the maintainers' preferred API direction.Validation on the current branch:
npm test: 48 passingnpx prettier --check index.ts test/test-python-shell.ts README.mdgit diff --check