datetime: propagate NaN for week and days_in_month with missing_values=ignore - #1017
Open
AlejandroCoronadoN wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
missing_values="ignore",DatetimeFeatures.transform()raises for theweekanddays_in_monthfeatures if the input has a missing date. Both cast tonp.int64, which fails on the NaT-derived NA:The other datetime features (month, year, day_of_month, ...) do not force an int cast and correctly return NaN for the missing row, so only these two were affected.
Repro:
This casts both to
float64instead, so the missing row becomes NaN like the other features. Added a test coveringweekanddays_in_monthwithmissing_values="ignore".