Add tus host config - #1
Draft
Caushi wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
xml/BioBeamerTus.xml— one host,testhost_tus, using the newtool="tus"backend.Why a separate file rather than an entry in BioBeamerTest.xml
The config XML is read by every host, but the XSD that validates it ships per BioBeamer
version. So the moment a
tus_*attribute appears in a shared file, every host still pinned to anolder version fails validation on every run — including robocopy hosts that have nothing to do with
tus.
Verified: this file validates against the new XSD and fails against the old one.
Keeping the tus host in its own file (pointed at by its own
launcher.inixml_file_path) meansnothing the fleet reads is touched. Before these hosts can be merged into the shared configs, the
xs:anyAttributeforward-compatibility fix in fgcz/BioBeamer#25 has to be back-ported and rolledout — after which unknown attributes stop being a fleet-wide breaking change.
The host
Points at the local dev stack: tus endpoint
localhost:1337/files, application 417 (an importapplication on storage 15, the TUS-enabled storage), container parsed from the path.
tus_container_pattern="p([0-9]+)"— the container comes from the file path, not the host, becauseone instrument writes data for many projects. There is deliberately no fallback: a path with no
recognisable container fails the run rather than guessing.
patternincludesbinso that nested files inside a.dbundle (sub/deep.bin) are not filteredout — a partially-filtered bundle cannot be uploaded as a single directory entry, which is what
preserves the internal structure as resource names.
Before real use
source_path,tus_endpointandapplicationIDare dev values and must be set per instrument.versionmust point at a BioBeamer ref that contains the tus backend.