Version 10.0.0 beta04 - #2384
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the form validation logic in SignUpUI.kt to only validate the display name if it is required by the provider, and adds a corresponding unit test in SignUpUITest.kt to verify this behavior. Feedback was provided regarding the use of derivedStateOf for isFormValid, which is an anti-pattern here because the inputs are plain strings rather than Compose State objects, leading to unnecessary allocations. Additionally, calling validate() inside the block causes side-effects during composition. It is recommended to simplify isFormValid to a plain Boolean using remember and update the button's enabled state accordingly.
84a8b5d to
d382bd5
Compare
d382bd5 to
1ecd498
Compare
|
Could you let me know the planned release |
|
Hi @vegeta2102 , we've got a couple of fixes/features we need to merge first, after which we'll get a release out in a couple weeks. |
…e with tooltip. BREAKING - Removed unused `newAccountsDisabledTooltip` from public interface `AuthUIStringProvider` (#2397)
…#2425) * fix(auth): pre-fill email when "Continue as" button is tapped (#2423) The "Continue as..." button displayed the saved identifier but discarded it on click, sending the user to a blank email form. Add an onContinueAsSelected callback to AuthMethodPicker that carries the identifier through to EmailAuthScreen, which now initializes the email field with the saved address. * fix(auth): only pre-fill email for Email provider, not phone/other * fix(auth): move new parameters to end of signature to preserve API compat * fix(auth): address review feedback for prefill email feature - Update kDoc to say "email address" instead of "phone number" since phone pre-fill is not wired up in this PR - Add SignInUITest with assertions for email pre-fill behavior * test(auth): cover AuthMethodPicker Continue-as button and onContinueAsSelected callback --------- Co-authored-by: demolaf <demolafadumo@gmail.com>
…a onSignInFailure (#2433)
dbaac07 to
f896825
Compare
3 participants
newAccountsDisabledTooltipfrom public interfaceAuthUIStringProvider#2397CancelledandAborted#2440Changes
fix(internal): append CHAR_LIMIT to translation descriptions in export script #2417
fix(auth): mitigate tapjacking on the auth activity window #2416
sample(app): add Firestore, Database & Storage demos to sample app #2406
fix(auth): allow customizing top app bar colors via AuthUITheme #2391
fix(auth): handle edge-to-edge insets in MFA challenge and auth screens #2413
fix(auth): stale one-off AuthState no longer leaks across screen instances #2415