Skip to content

[Infra] Upgrade the Kotlin compiler to 2.3.21 - #8596

Merged
rlazo merged 6 commits into
mainfrom
rl/bump_compiler
Sep 15, 2026
Merged

rlazo merged 6 commits into
mainfrom
rl/bump_compiler

Conversation

@rlazo

@rlazo rlazo commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Updated the Kotlin compiler to version 2.3.21, and updated KSP plugin and Symbol Processing API versions to 2.3.6 to be able to use it.

Explicitly set the Kotlin language version and core libraries version in FirebaseJavaLibraryPlugin to remain in 2.1.x

NO_RELEASE_CHANGE

Updated the Kotlin compiler to version 2.3.21, and updated KSP
plugin and Symbol Processing API versions to 2.3.6 to be able to use it.

Explicitly set the Kotlin language version and core libraries version
in `FirebaseJavaLibraryPlugin` to remain in 2.1.x
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

plugins test results

69 tests   69 ✅  1m 17s ⏱️
12 suites   0 💤
12 files     0 ❌

Results for commit 5cd3999.

♻️ This comment has been updated with latest results.

@rlazo

rlazo commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Kotlin and KSP dependency versions across the project, configures the Kotlin language version to 2.1, and sets the core libraries version in the Firebase Java library plugin. Feedback is provided regarding the use of project.afterEvaluate in the plugin, which is a Gradle anti-pattern; it is recommended to use project.plugins.withId instead to reactively configure the Kotlin extension.

It should be moved from KAPT into KSP. Since there's no plan on
releasing a newer version, we can postpone this change for now
@rlazo
rlazo requested review from emilypgoogle and removed request for milaGGL September 15, 2026 16:31
@rlazo
rlazo merged commit 8186964 into main Sep 15, 2026
182 of 188 checks passed
@rlazo
rlazo deleted the rl/bump_compiler branch September 15, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants