Sync the publish branch into main - #32
Open
Fiona2016 wants to merge 7 commits into
Open
Conversation
Bring main onto the release line
Duplicate each success notification step to post to a second DingTalk robot via the DING_TALK_TOKEN_2 / DING_TALK_SECRET_2 secrets. Failure notifications are unchanged and still go to the original robot only.
…-group ci: also send release success notifications to a second DingTalk group
The release workflow treated the DingTalk notification as a build gate: when the robot API rejects a message -- for example once its per-minute rate limit is exhausted -- the notification step failed and marked an otherwise successful publish as failed. Set `ignoreError` on every DingTalk step so a rejected notification is reported as a warning instead of failing the job. The publish outcome no longer depends on the notification channel.
The repository formats YAML with `singleQuote`, so the double-quoted value failed the format check.
…rror ci: do not fail a release when the DingTalk notification fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publishcarries the releases — npm is at the version it holds and the release tags sit on it — and it has drifted seven commits ahead ofmainsince the last reconciliation. Bringing them back level keeps either branch a place you can release from, and spares the next person working out which one is true.mainhas nothing of its own here: it is strictly behind, so this is a fast-forward and nothing had to be resolved.What comes across
v0.1.0, the release itselfAll of it is release plumbing; no product code changes.
What this does not carry
The remote sampling configuration work is still open in #30 against
publish, so none of it is here. This sync is only about the seven commits above.