docs(rum-legacy): name the current release in the bundle urls - #35
Closed
Fiona2016 wants to merge 1 commit into
Closed
docs(rum-legacy): name the current release in the bundle urls#35Fiona2016 wants to merge 1 commit into
Fiona2016 wants to merge 1 commit into
Conversation
A placeholder makes the reader look the version up before they can fetch anything. Release directories are never overwritten, so a url that names one keeps working: a version that falls behind hands back an older bundle, where the unreleased one it replaced returned 404.
Collaborator
Author
|
Superseded: the bundle urls will keep the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #34, which left the bundle urls with a
<version>placeholder.A placeholder makes the reader look the version up before they can fetch anything, and the reason the previous version was written as one does not hold: release directories are never overwritten, so a url that names a release keeps working indefinitely. A named version that falls behind hands back an older bundle — the failure #34 fixed was a version that was never released at all, which returned 404.
So the urls name
v0.1.0, the current release and the first to carry this build, and the sentence below them says so.Verification
fc-rum-legacy.js(11880 bytes),flashcat-rum.js("0.1.0").prettier --checkpasses.<script>snippets still finds and passes 2 snippets; no snippet was touched.One thing this does not solve
The version is now a literal that a release does not update, so it goes stale on the next one. That is a smaller failure than the one it replaces — an older bundle rather than a 404 — but it is the same shape of problem. Worth a CI assertion that the version in this README matches
lerna.json;scripts/check-es5-compatibility.jsalready reads this file and would be the place for it. Left out of this PR because it changes what can block a release.