overlay baselayout: symlink networks, protocols, rpc, services into /etc - #4190
Draft
dongsupark wants to merge 1 commit into
Draft
overlay baselayout: symlink networks, protocols, rpc, services into /etc#4190dongsupark wants to merge 1 commit into
dongsupark wants to merge 1 commit into
Conversation
Pulls in flatcar/baselayout#44. Signed-off-by: Dongsu Park <dongsu@dpark.io>
There was a problem hiding this comment.
Pull request overview
Updates the Flatcar sys-apps/baselayout overlay package to a baselayout commit that adds tmpfiles “L” symlinks so /etc/protocols, /etc/services, /etc/rpc, and /etc/networks exist on-disk (improving compatibility with static/Go binaries and Kubernetes hostPath type: File).
Changes:
- Bump the baselayout distfile referenced by the ebuilds/Manifest to commit
a84fe9fe7c680a9de488ed58f85debf08432cbdd. - Add a new versioned ebuild
baselayout-3.6.8-r23pinned to that commit. - Update the existing
baselayout-9999.ebuild(non-9999branch metadata) to the same commit.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk_container/src/third_party/coreos-overlay/sys-apps/baselayout/Manifest | Updates the distfile checksum/size for the new baselayout commit tarball. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/baselayout/baselayout-9999.ebuild | Updates the pinned commit metadata in the non-live code path. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/baselayout/baselayout-3.6.8-r23.ebuild | Introduces a versioned, keyworded ebuild pinned to the baselayout commit containing the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in flatcar/baselayout#44.
/etc/protocols,/etc/services,/etc/rpcand/etc/networksare not on disk in flatcar. Glibc finds them under/usr/share/baselayout/through theusrfilesNSS module wired up innsswitch.conf, sogetprotobyname()and friends work fine and nothing looks broken.Anything that opens those paths directly does break though. Statically linked binaries and go programs parse
/etc/protocolsthemselves, and kubernetes workloads that mount the file as ahostPathwithtype: Filedo not even start, because kubelet requires the path to exist on the host, this is what azure-npm runs into.So this PR adds four
Llines tobaselayout-etc.confpointing back at the copies in/usr/share/baselayout/, exactly how/etc/nsswitch.confand/etc/issueare already handled.Lleaves an existing path alone, so anyone who put their own file in/etckeeps it./cc @satwiksps
Fixes flatcar/Flatcar#1852
Testing done
CI: https://jenkins.flatcar.org/job/container/job/sdk/130/cldsv/
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.