Bump jsdom from v28 to v29, update CI node matrix - #50
Merged
Merged
Conversation
jsdom 29 requires Node ≥22.13.0, so drop Node 20 (now EOL) from CI and add Node 24 (current release) alongside Node 22 (active LTS).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why v29 and not v30?
jsdom 30 has a bug in its new CSSOM implementation where
getComputedStylereturnsborderTopWidth: "16px"for all elements, even whenborderStyleis"none". Per the CSS spec, computed border-width should resolve to0pxwhen border-style is none. This breaks our coordinate scaling tests (25 failures) since the plugin reads padding/border insets fromgetComputedStyleto calculate content area dimensions.Sticking with v29 until that's sorted.
Test plan