fix(async-fsspec): propagate concurrent download failures - #3464
Open
1fanwang wants to merge 1 commit into
Open
Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
requested review from
cosmicBboy,
davidmirror-ops,
kumare3,
machichima,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
September 3, 2026 07:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
None.
Why are the changes needed?
Concurrent S3 downloads could return success after a ranged request failed. The caller received a partial file while asyncio logged
Task exception was never retrieved.What changes were proposed in this pull request?
Read completed task results so download errors reach the caller. On failure or cancellation, cancel and await the remaining chunk tasks.
How was this patch tested?
This command uses the real
s3fsandaiobotocoreHTTP path:Setup process
The expected file was
4142434445464748. Plugin tests pass.Screenshots
Not applicable.
Check all the applicable boxes
Related PRs
None.
Docs link
Not applicable.