chore: bump version to 0.1.4 for the activate target-platform and error-logging fixes - #80
Merged
Merged
Conversation
…d as {}
Two real bugs surfaced by testing unity-activate's thin-wrapper PR against
this repo's freshly-merged activate command:
- ActivateCommand inherited UnityOptions' build-oriented targetPlatform
default (StandaloneWindows64), so a bare `game-ci activate <path>` -
exactly what the thin wrapper calls - threw "Windows-based builds are
only supported on 2019.3.X+" for any older Unity version, even though
activation doesn't build anything. Defaults to NoTarget instead, which
RunnerImageTag already maps to the generic image and skips build-target
validation entirely. Explicit --target-platform still works.
- log.error()'s JSON.stringify fallback silently produces '{}' for any
bare Error, since message/stack/name are non-enumerable own properties.
This was masking the actual error above and likely every other uncaught
failure in the CLI. Error objects are now special-cased to print their
stack.
…or-logging fixes (#79)
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for cutting a new release so
cliVersion: latest(unity-activate#111, unity-builder#844's thin wrappers) actually picks up #79's fixes —v0.1.3predates that PR.