fix: NoTarget resolved to a Docker tag unityci/editor never publishes - #82
Merged
Conversation
RunnerImageTag mapped both NoTarget and the internal 'Test' targetPlatform to the same empty suffix, producing tags like "ubuntu-2019.2.17f1-3" - unityci/editor always has a module suffix (base/webgl/android/etc.), so this is never a real image. `docker pull` failed with "manifest unknown" on every version. Surfaced by unity-activate#111's thin-wrapper CI: `game-ci activate` defaults targetPlatform to NoTarget (#79) and hit this on every job. 'base' is the same image StandaloneLinux64 (pre-il2cpp) already resolves to - the right choice for "just an editor, no specific build target". Split into its own noTarget suffix rather than reusing generic, since 'Test' also used generic and doesn't pull real images - no reason to touch its behavior.
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third bug in the same chain as #79, found by actually re-running unity-activate#111's CI against the new v0.1.4 release.
The bug
RunnerImageTag.targetPlatformSuffixes.genericwas''. BothNoTargetand the internalTesttargetPlatform resolved through it, producing tags likeunityci/editor:ubuntu-2019.2.17f1-3. Every realunityci/editorimage has a module suffix (base,webgl,android,windows-mono, etc.) — this tag has never existed, sodocker pullfailed withmanifest unknownon every single job.The fix
NoTargetnow resolves to'base'— the same imageStandaloneLinux64(pre-il2cpp) already uses. That's the right image for "just give me an editor, not tied to any build target," which is exactly whatactivateneeds.Split into its own
noTargetsuffix key rather than just fixinggenericin place, becauseTest(unit-test scaffolding, never a real Docker pull) also went throughgeneric— changing that value broke several existing test assertions that don't care about real Docker Hub tags.Testkeeps the old empty-suffix behavior; onlyNoTargetchanges.How I found it
Re-ran unity-activate#111's CI once v0.1.4 (with #79's fixes) was published. #79 got it past engine detection and the target-platform validation; this is what showed up next.
Testing
runner-image-tag.test.ts's existingNoTargettest, which had codified the buggyubuntu-2019.2.11f1-3tag as expected output — now assertsubuntu-2019.2.11f1-base-3/windows-2019.2.11f1-base-3.bun run test— 147 pass, 3 skip, 0 fail.🤖 Generated with Claude Code