Add an integration test for node deletion - #1126
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gardener-prow
Bot
added
do-not-merge/needs-kind
aaronfern
added
kind/test
gardener-prow
Bot
added
cla: yes
thiyyakat
left a comment
thiyyakat
left a comment
There was a problem hiding this comment.
Thanks for the changes! The test looks good to me. I just had a few questions about possible behaviour.
gardener-prow
Bot
added
the
size/M
| ginkgo.Context("node deletion", func() { | ||
| ginkgo.It("should delete machine resource when node resource is deleted", func() { | ||
| ginkgo.By("Create machine") | ||
| gomega.Expect(c.ControlCluster.CreateMachine(controlClusterNamespace, gnaSecretNameLabelValue)).To(gomega.BeNil()) |
There was a problem hiding this comment.
Just a thought, to save time, could we have this machine creation along with the creation on the other test-machine (L659). This way, we can save time on machine creation, and still have it be part of the core machine tests.
3 participants
What this PR does / why we need it:
This PR add an integration test to verify if machine deletion happens when node deletion is triggered
Which issue(s) this PR fixes:
Fixes partially #1123
Special notes for your reviewer:
Release note: