ci(desktop): guard Windows installer artifacts - #995
Draft
avs-io wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The desktop release pipeline did not enforce that Windows NSIS installer artifacts (
.exe) were produced and verified alongside macOS and Linux builds, leaving distribution asset availability open to platform build drops.Root cause
The GitHub Actions workflow lacked a strict verification step ensuring
.exeartifacts were built and signed before publishing release assets, and release documentation did not state the mandatory asset set.Change
.github/workflows/build-windows-installer.ymlto build and verify Windows NSIS installer artifacts.app/scripts/verify-windows-installer.mjsand comprehensive unit testsapp/scripts/verify-windows-installer.test.ts.RELEASING.mdandapp/DISTRIBUTION.mdto document mandatory Windows installer verification.User impact
Release assets for desktop releases are guaranteed to include verified
.exeinstallers for Windows users.Preservation and out of scope
Testing
app/scripts/verify-windows-installer.test.tspass.npx tsc --noEmitclean.