fix(snapshots): Upload empty selective manifests - #3395
Merged
Conversation
Create a snapshot artifact when a selective upload has no image bytes but includes the complete image filename manifest. Refs EME-1290
jamieQ
force-pushed
the
fix/allow-empty-selective-snapshots
branch
from
August 18, 2026 20:32
18660a6 to
23e7bf9
Compare
jamieQ
marked this pull request as ready for review
August 18, 2026 20:37
NicoHinderling
approved these changes
Aug 19, 2026
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
Member
There was a problem hiding this comment.
relying on @NicoHinderling's review, I think the code owners rule only triggered due to the addition of _fixtures/empty_snapshots/README.md
szokeasaurusrex
approved these changes
Aug 27, 2026
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the
snapshots uploadcommand to successfully upload an empty set of images during a "selective" image upload. This allows improved PR feedback when a selective upload does not actually change the set of snapshot images. See getsentry/cli#1397 for more background.Refs EME-1290