feat(core)!: Enable data collection by default (based on spec) - #22917
Merged
Conversation
s1gr1d
requested review from
andreiborza,
chargome,
isaacs,
logaretm and
msonnb
and removed request for
a team
July 31, 2026 12:28
s1gr1d
marked this pull request as draft
July 31, 2026 12:28
Contributor
size-limit report 📦
|
s1gr1d
commented
Jul 31, 2026
Member
Author
There was a problem hiding this comment.
We now collect 5 lines instead of 7. Based on spec: https://develop.sentry.dev/sdk/foundations/client/data-collection/#datacollection-options
# Conflicts: # packages/browser/test/client.test.ts # packages/browser/test/integrations/httpclient.test.ts # packages/core/test/lib/integrations/supabase.test.ts # packages/core/test/lib/logs/internal.test.ts # packages/core/test/lib/metrics/internal.test.ts # packages/core/test/lib/tracing/spans/captureSpan.test.ts # packages/core/test/lib/tracing/spans/envelope.test.ts # packages/core/test/lib/utils/data-collection/resolveDataCollectionOptions.test.ts # packages/core/test/lib/utils/request.test.ts # packages/deno/test/deno-serve.test.ts
Member
Author
|
@BugBot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
s1gr1d
changed the title
…tTag test The script tag line following the button varies by test variant: CDN bundle runs inject additional `cdn.bundle.js` and `contextlines.bundle.js` tags on that line, so a hardcoded literal only matches the tarball build and fails in every bundle job. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
With `dataCollection.userInfo` defaulting to true, the Hono middleware now attaches the client IP via `setUser()`. The envelope matcher compares events strictly, and the runner silently discards non-matching envelopes in unordered mode, so the missing key surfaced as a test timeout rather than an assertion failure. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
With `dataCollection.databaseQueryData` defaulting to true, Supabase breadcrumbs now carry a `data.query` payload. The breadcrumb assertions compare objects exactly, so the added key made them fail. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
|
buglitzer moch |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5c73912. Configure here.
chargome
marked this pull request as ready for review
August 3, 2026 13:22
nicohrubec
approved these changes
Aug 3, 2026
| expect(client.getOptions()._metadata?.sdk?.settings?.infer_ip).toBe('never'); | ||
| }); | ||
|
|
||
| it('sets infer_ip to "never" if dataCollection.userInfo is false', () => { |
Member
There was a problem hiding this comment.
m: should we not keep these to test the case where users explicitly opt out?
Member
There was a problem hiding this comment.
Good call, but these are covered already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First merge this PR (is merged): #22913
Enable the
dataCollectionspecification defaults when neitherdataCollectionnor the legacysendDefaultPiioption is configured.Tests and development test applications now rely on the new defaults instead of redundantly opting into
userInfoand related data.closes #22707