ref: add sentry_attachment_t accessors - #2009
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2009 +/- ##
==========================================
- Coverage 74.69% 74.37% -0.32%
==========================================
Files 104 104
Lines 26182 26563 +381
Branches 4740 4834 +94
==========================================
+ Hits 19557 19757 +200
- Misses 5295 5464 +169
- Partials 1330 1342 +12 🚀 New features to boost your workflow:
|
limbonaut
approved these changes
Aug 25, 2026
limbonaut
left a comment
limbonaut
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Just need a null check in one place.
Comment on lines
+739
to
+740
| sentry_path_t *path = sentry__attachment_make_path(attachment); | ||
| item = sentry__envelope_add_from_path(envelope, path, "attachment"); |
Collaborator
There was a problem hiding this comment.
Should we check if path allocation was successful?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a non-breaking preparation step for the breaking stacked PR:
This adds internal accessors for attachment properties, reducing direct access to the
sentry_attachment_sdata structure and moving mechanical churn out of #1974. This makes the large value-based attachment migration slightly smaller, easier to review, and less conflict-prone without changing behavior, and helps with partial pre-migration of console repos.#skip-changelog (internal)