Skip to content

ref: Drop 3.6 in new major - #6904

Merged
sentrivana merged 14 commits into
major/3.0from
ivana/major/drop-3.6
Aug 4, 2026
Merged

ref: Drop 3.6 in new major#6904
sentrivana merged 14 commits into
major/3.0from
ivana/major/drop-3.6

Conversation

@sentrivana

@sentrivana sentrivana commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

Drop 3.6 from tests, utils, etc.

CI failures should be unrelated (coming from toxgen update, once fixed on master they'll resolve here as well).

Ignore the diff size; it's mostly tox.ini and friends.

Issues

Closes #5040

Reminders

@sentrivana sentrivana changed the title Drop 3.6 Drop 3.6 in new major Jul 28, 2026
@sentrivana
sentrivana marked this pull request as ready for review July 28, 2026 11:53
@sentrivana
sentrivana requested a review from a team as a code owner July 28, 2026 11:54
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

89557 passed | ❌ 1 failed | ⏭️ 5464 skipped | Total: 95022 | Pass Rate: 94.25% | Execution Time: 326m 60s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -6780
Passed Tests 📉 -6006
Failed Tests 📈 +1
Skipped Tests 📉 -775

➕ New Tests (1)

View new tests
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[experiment-gevent]
    • File: tests.profiler.test_continuous_profiler
    • Status: ❌ Failing

❌ Failed Tests

test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[experiment-gevent]

File: tests.profiler.test_continuous_profiler
Suite: py3.7-gevent
Error: AssertionError: profiler should not be running assert 'e268ab0827534e3f84f5ffdb46989257' is None + where 'e268ab0827534e3f84f5ffdb46989257' = get_profiler_id()

Stack Trace
tests/profiler/test_continuous_profiler.py:896: in test_continuous_profiler_auto_start_and_stop_sampled_span_streaming
    assert get_profiler_id() is None, "profiler should not be running"
E   AssertionError: profiler should not be running
E   assert 'e268ab0827534e3f84f5ffdb46989257' is None
E    +  where 'e268ab0827534e3f84f5ffdb46989257' = get_profiler_id()

❌ Patch coverage is 43.48%. Project has 2371 uncovered lines.
✅ Project coverage is 90%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/aws_lambda.py 0.00% ⚠️ 13 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.92%    90.00%    +0.08%
==========================================
  Files          193       186        -7
  Lines        24825     23703     -1122
  Branches      8912      8558      -354
==========================================
+ Hits         22321     21332      -989
- Misses        2504      2371      -133
- Partials      1414      1376       -38

Generated by Codecov Action

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e4667d4. Configure here.

Comment thread scripts/populate_tox/config.py
@sentrivana sentrivana changed the title Drop 3.6 in new major ref: Drop 3.6 in new major Jul 29, 2026
@sentrivana
sentrivana merged commit f355378 into major/3.0 Aug 4, 2026
127 of 128 checks passed
@sentrivana
sentrivana deleted the ivana/major/drop-3.6 branch August 4, 2026 08:21
sentrivana added a commit that referenced this pull request Aug 4, 2026
### Description

Drop the contextvars compatibility layer that supported Python 3.6
(aiocontextvars), old gevent (<20.9.0), and old greenlet (<0.5).

Warn if using an older version of either during setup.

This allows us to remove the whole machinery around checking whether
contextvars are safe to use and replacing them if not.

Note: 3.6 tests are expected to fail on this. They'll be dropped in
#6904

#### Issues
Closes #5037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants