Rust: Avoid path resolution in Element.toString - #22520
Draft
hvitved wants to merge 1 commit into
Draft
Conversation
hvitved
force-pushed
the
hvitved-rust-tostring-implementations
branch
from
September 7, 2026 13:37
e9b934f to
f6c238f
Compare
Define string representations on concrete element classes, make existing renderers total when unresolved child data is absent, and remove the path-resolution-dependent fallback from Element. Add a consistency check for elements that lack a string representation and update generated-file metadata for customized wrappers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hvitved
force-pushed
the
hvitved-rust-tostring-implementations
branch
from
September 7, 2026 17:29
f6c238f to
90e99fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
Element.toString()independent of path resolution by replacing itsgetAPrimaryQlClass()fallback with"???"and defining equivalent primary-classtoStringImpl()implementations on the concrete element classes that need them.Add an AST consistency predicate that identifies elements whose string representation is missing or still uses the fallback.
Testing
codeql query compile rust/ql/consistency-queries/AstConsistency.ql