Improve hapi coverage - #22522
Draft
jacknojo wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The false negative reproduced on this PR as a regression test had four separate breaks in the flow:
server.route(config)was ignored whenconfigcame from a helper, likeserver.route(makeConfig(handler)).request.queryobject was not treated as a source.definition.handler.call(...)had no resolved target.createCacheddid not reach the wrapped function:hapiRequeststops at...args.In
javascript/ql/lib/semmle/javascript/frameworks/Hapi.qllwe:routeandextcalls independently of whether their handlers can immediately be resolved. We backtrack to find thehandler.request.query,request.params, andrequest.payloadacross supported data-flow steps and mark fields read from those values as sources, including reads in functions called by the handler. This follows the existing Express modeling pattern.handlerproperty with later calls to that property on the same definition object. Other property names than "handler" are not currently supported.For
javascript/ql/lib/semmle/javascript/dataflow/internal/FunctionWrapperSteps.qllcreateCached(fn)as a forwarding wrapper, including the rest/spread pattern(...args) => fn(...args).This is a change to the overall JavaScript CodeQL code and I am not sure if this is correct.