fix(pull): allow re-request after stale review request - #38721
Open
lunny wants to merge 1 commit into
Open
Conversation
Co-authored-by: Codet <codet@noreply.gitea.com>
Zettat123
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Legacy or imported data can contain an old
ReviewTypeRequestrow alongside a newerReviewTypeCommentrow. The sidebar treats the newer comment as the current state, whileAddReviewRequestpreviously ignored comments and silently returned after finding the stale request. As a result, re-requesting a review appeared to do nothing.This change repairs the inconsistent state through the normal application path without requiring a migration or a doctor command.
Verification
go test ./models/issues/...go test ./models/...go test ./services/issue/...go build ./...go vet ./models/issues/...make fmtgit diff --checkmake lint-gocould not complete because the localgo-criticruleguard loader panics while loadingfmt. The same panic reproduces on the unmodified base commit.Generated by Codet