[bot] Merge master/40634f74 into rel/dev - #1782
Merged
Merged
Conversation
knowledge_question had reclassified fixtures (commit 658b9ea6) but no registered evaluator, so get_evaluator() raised KeyError and every item was silently skipped -- data/test_kinds.yaml had to keep it disabled. Reuses GeneralQuestionEvaluator directly: both are free-text-rubric, LLM-judged prose answers, and ItemReport.test_kind is tagged from the dataset item's own field rather than the evaluator class, so sharing one class across both kinds doesn't mislabel results.
…ual test_kind use Addresses two of hkad98's non-blocking nits on #1763: - supported_test_kinds()'s docstring only listed (general_question, guardrail) as the LLM-judge kinds; dashboard_summary and knowledge_question were already excluded by the same check but never mentioned. - GeneralQuestionEvaluator.test_kind is now inaccurate for half its registrations (knowledge_question shares the class) -- added a pointer to the registry comment explaining why, so a future reader doesn't derive an output label from it without realizing. Third nit (no agentic_knowledge_question dispatch branch) left as scope, per the review comment's own "fine as scope, likely next request."
feat(gooddata-eval): register knowledge_question evaluator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1782 +/- ##
===========================================
+ Coverage 81.68% 81.70% +0.02%
===========================================
Files 275 275
Lines 19848 19848
===========================================
+ Hits 16212 16217 +5
+ Misses 3636 3631 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 40634f7 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/33870032855).