fix: use Optional[] instead of X | None in cleanup_unused_files signature - #6552
Open
guptaishaan wants to merge 1 commit into
Open
fix: use Optional[] instead of X | None in cleanup_unused_files signature#6552guptaishaan wants to merge 1 commit into
guptaishaan wants to merge 1 commit into
Conversation
…ture The `cleanup_unused_files` tool used the `X | None` union syntax (PEP 604) for its `file_patterns` and `exclude_patterns` parameters. ADK's automatic function calling schema parser does not support this syntax and raises a "Failed to parse the parameter" error at runtime, breaking the builder assistant chat. Signed-off-by: Ishaan <ishaangupta0408@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cleanup_unused_filestool used theX | Noneunion syntax (PEP 604) for itsfile_patternsandexclude_patternsparameters. ADK's automatic function calling schema parser does not support this syntax and raises a "Failed to parse the parameter" error at runtime, breaking the builder assistant chat.The fix replaces
list[str] | NonewithOptional[list[str]]from thetypingmodule for both parameters. This is semantically equivalent and is correctly handled by the schema generator.Fixes #3591.