Restructure cvdalloc to use nftables + Test cvdalloc using the host sandbox - #2878
Draft
dxapd wants to merge 7 commits into
Draft
Restructure cvdalloc to use nftables + Test cvdalloc using the host sandbox#2878dxapd wants to merge 7 commits into
dxapd wants to merge 7 commits into
Conversation
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
dxapd
force-pushed
the
nftables-cvdalloc-1
branch
from
July 21, 2026 22:02
fab4f34 to
73880b5
Compare
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
dxapd
force-pushed
the
nftables-cvdalloc-1
branch
from
August 5, 2026 23:47
73880b5 to
f53819a
Compare
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
dxapd
force-pushed
the
nftables-cvdalloc-1
branch
2 times, most recently
from
August 20, 2026 21:36
aeb023a to
e09be53
Compare
dxapd
force-pushed
the
nftables-cvdalloc-1
branch
from
August 25, 2026 04:40
d6b7b65 to
6bce8cb
Compare
dxapd
changed the title
…sfy the formatters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a huge PR, but thankfully it has two mostly separate logical pieces.
First, the changes to cvdalloc itself. In the process of migrating cvdalloc to use nftables, I thought it would be good to restructure it to enforce rule cleanup using RAII.
Second, sandboxed testing for cvdalloc. This is building on #2959 to do snapshot-based diff testing of the host's state during cvdalloc runs, so we can more accurately test that cvdalloc makes the right changes to the state of the host system.
These live in separate folders, so they can be reviewed (mostly) separately, but I think they should go in together.