Add missing 'unset' in config flag vectorizing - #3043
Open
almuthanna-athamina wants to merge 1 commit into
Open
Conversation
jmacnak
approved these changes
Aug 18, 2026
Databean
force-pushed
the
fix-config-flag-unset-vectorizing
branch
from
August 19, 2026 14:39
fbc40dd to
946e338
Compare
Member
|
Note: ag/41631463 |
Databean
force-pushed
the
fix-config-flag-unset-vectorizing
branch
from
August 24, 2026 22:24
946e338 to
1c2a64d
Compare
Member
|
There's a failure in |
When launching multi-device or multi-VM cuttlefish instances with heterogeneous configuration presets (e.g. --config=sdv_core_instance1,phone or --config=wear,phone), instances that omit a specific flag are padded with "unset" so that per-instance flags are properly aligned across instances. Previously, setting the gflags default with SET_FLAGS_DEFAULT when the value contained "unset" poisoned the gflags default table, causing GetFlag*ValueForInstances to parse "unset" as a boolean/integer and abort during assembly. Furthermore, non-vectorized flags (like display0..3, touchpad, custom_actions, extra_bootconfig_args, secure_hals, etc.) were incorrectly comma-vectorized with "unset", breaking their syntax. This change: 1. Adds defensive checks in GetFlagBoolValueForInstances, GetFlagIntValueForInstances, and GetFlagStrValueForInstances to fall back safely to a non-unset default when an instance is marked "unset". 2. Handles "unset" in default_vvmtruststore_file_name gracefully in resolve_instance_files. 3. Skips "unset" padding in config_flag for non-vectorized flags (display0..3, custom_actions, touchpad, extra_bootconfig_args, secure_hals, extra_kernel_cmdline, gem5_debug_flags, group_id, straced_host_executables, and flags prefixed with webrtc_ or ap_). 4. Adds a fail-fast CF_EXPECTF check if any future unlisted flag contains commas in its preset value when being vectorized. Bug: 354927775, 543955575
almuthanna-athamina
force-pushed
the
fix-config-flag-unset-vectorizing
branch
from
August 28, 2026 10:28
1c2a64d to
f50a13b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix multi-instance default flag resolution in config_flag.cpp by populating missing instance flags with "unset". This ensures that unspecified instance flags fall back to their per-instance defaults rather than inadvertently replicating the primary instance's settings.
Bug: 354927775, 543955575