[VRP] Harden testcase safety check in long-lived bots - #5368
Merged
Merged
Conversation
PauloVLB
force-pushed
the
vrp-untrusted-testcase-safety
branch
5 times, most recently
from
July 16, 2026 20:37
627f503 to
6a39d40
Compare
PauloVLB
changed the base branch from
master
to
vrp-untrusted-testcases-from-fuzzers
July 16, 2026 20:39
PauloVLB
force-pushed
the
vrp-untrusted-testcase-safety
branch
from
July 16, 2026 20:59
6a39d40 to
20c1288
Compare
PauloVLB
force-pushed
the
vrp-untrusted-testcase-safety
branch
from
August 10, 2026 14:13
20c1288 to
3f3929c
Compare
Base automatically changed from
vrp-untrusted-testcases-from-fuzzers
to
master
August 12, 2026 16:22
PauloVLB
force-pushed
the
vrp-untrusted-testcase-safety
branch
6 times, most recently
from
August 28, 2026 18:58
0c32e20 to
91ca0c6
Compare
PauloVLB
marked this pull request as ready for review
August 28, 2026 19:01
dylanjew
reviewed
Aug 28, 2026
PauloVLB
force-pushed
the
vrp-untrusted-testcase-safety
branch
from
August 31, 2026 13:39
91ca0c6 to
40ad82f
Compare
dylanjew
approved these changes
Aug 31, 2026
ViniciustCosta
approved these changes
Sep 1, 2026
PauloVLB
force-pushed
the
vrp-untrusted-testcase-safety
branch
from
September 2, 2026 13:38
40ad82f to
1bea54b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long-lived bots shouldn't be handling untrusted testcases locally (like during minimization, analyze, regression or variant tasks). The old check used the
UNTRUSTED_UTASKenv var with just a warning, which wasn't reliable.Proposed Solution
Harden
check_handling_testcase_safeinuworker_io.pyto checktestcase.trustedandenvironment.is_uworker(). If a long-lived bot (is_uworker()is False) tries to handle an untrusted testcase, it will immediately exit with a fatal error. Also aligned its behavior and return values withcheck_running_fuzzer_safe.Notes on TODOs
task_creation.py(create_variant_tasks_if_needed) because untrusted testcase handling is already covered.corpus_pruning_task.pyto specify "engine fuzzing": the untrusted testcases we are supporting are strictly for blackbox fuzzing, which do not reach the corpus prunning task.Testing
uworker_io_test.pycovering trusted testcases, untrusted testcases on uworkers, and fatal exits on long-lived bots.test_utils.py,utask_helpers.py,minimize_task_test.py) to default testcases totrusted=Trueso unrelated tests don't trigger the fatal safety check.