Use cancel-in-progress instead of styfle/cancel-workflow-action. - #1442
Merged
Conversation
Compare google/guava#8542. Aside from the reasons listed there, I wonder if this would have avoided a flaky(?) failure that I saw today on google#1441: ``` Run styfle/cancel-workflow-action@d07a454 with: access_token: *** ignore_sha: false all_but_latest: false force_cancel: false { eventName: 'pull_request', sha: 'ca5f660437c7f1489d511540cf8c6d047ea0edcf', headSha: 'a160145b17ff487adfa4519b087472e3d328088d', branch: 'zizdep', owner: 'google', repo: 'google-java-format', GITHUB_RUN_ID: '31412633123' } Found token: yes Error: self-signed certificate; if the root CA is installed locally, try running Node.js with --use-system-ca ```
This was referenced Aug 10, 2026
When we use `vX` instead, `zizmor` complains about values like `0def53c0fd8534bc13416c9469f5be45265824fd # v1`: That commit was `v1.6.3`, which `v1` presumably _used_ to point to (so it _was_ fine), but now `v1` points to `v1.6.4`, which is a different commit. (I wonder if out-of-sync comments still ever [prevent Dependabot from updating them](https://github.com/dependabot/dependabot-core/issues/13197#issuecomment-3357374469)—though the case here seems different than that one.) Current [warning](https://docs.zizmor.sh/audits/#ref-version-mismatch): ``` ref-version-mismatch Check warning: ref-version-mismatch ci.yml:98: action's hash pin has mismatched or missing version comment: points to commit 5298d94fb55a ```
This was referenced Aug 10, 2026
cpovirk
added a commit
to google/error-prone
that referenced
this pull request
Aug 10, 2026
cpovirk
added a commit
to google/turbine
that referenced
this pull request
Aug 10, 2026
Update `oracle-actions/setup-java` along the way. This prevents the `zizmor` trouble seen in google/google-java-format#1442.
cpovirk
added a commit
to google/turbine
that referenced
this pull request
Aug 10, 2026
cpovirk
added a commit
to google/error-prone
that referenced
this pull request
Aug 10, 2026
Update `oracle-actions/setup-java` along the way. This prevents the `zizmor` trouble seen in google/google-java-format#1442.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare google/guava#8542.
Aside from the reasons listed there, I wonder if this would have avoided a flaky(?) failure that I saw today on #1441: