Extract slice metadata without references - #3629
Conversation
Generated KnownLayout implementations called pointer_to_metadata through a concrete trailing type. A same-named inherent method could therefore capture the call and supply metadata that violates the unsafe trait's layout contract. Emit a fully trait-qualified call for both the derived type and its generated MaybeUninit form. Extend the output hygiene check to reject unqualified associated-item syntax, and add compile-time and semantic regressions for an inherent-method collision. Closes #3621 *Authored by an AI agent acting on Josh Liebow-Feeser's behalf.* gherrit-pr-id: Gkpenpjjuex55evmm52puxsa34xtjgc7t
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gkpenpjjuex55evmm52puxsa34xtjgc7t #3629 +/- ##
=====================================================================
+ Coverage 91.85% 91.89% +0.03%
=====================================================================
Files 20 20
Lines 6093 6118 +25
=====================================================================
+ Hits 5597 5622 +25
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
KnownLayout's slice implementation materialized a shared reference solely to read raw pointer metadata. That is invalid for null, dangling, unaligned, or otherwise non-dereferenceable slice pointers even though metadata extraction itself must accept them. Use the safe raw-slice pointer length API on Rust 1.79 and newer. On older supported compilers, capture a metadata candidate through raw-pointer hashing and authenticate it with raw slice pointer equality before returning it. Strengthen the implementer contract and cover null, dangling, deallocated, unaligned, derived-DST, and boundary-toolchain cases. Closes #3615 *Authored by an AI agent acting on Josh Liebow-Feeser's behalf.* gherrit-pr-id: Gro7m5vgpfdcy3pxtpl52hnbgworclnzw
2e0e5c5 to
89f6867
Compare
|
@codex review Authored by an AI agent acting on Josh Liebow-Feeser's behalf. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
3 participants
KnownLayout's slice implementation materialized a shared reference solely to
read raw pointer metadata. That is invalid for null, dangling, unaligned, or
otherwise non-dereferenceable slice pointers even though metadata extraction
itself must accept them.
Use the safe raw-slice pointer length API on Rust 1.79 and newer. On older
supported compilers, capture a metadata candidate through raw-pointer hashing
and authenticate it with raw slice pointer equality before returning it.
Strengthen the implementer contract and cover null, dangling, deallocated,
unaligned, derived-DST, and boundary-toolchain cases.
Closes #3615
Authored by an AI agent acting on Josh Liebow-Feeser's behalf.
Latest Update: v2 — Compare vs v1
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gro7m5vgpfdcy3pxtpl52hnbgworclnzw && git checkout -b pr-Gro7m5vgpfdcy3pxtpl52hnbgworclnzw FETCH_HEADCheckout
git fetch origin refs/heads/Gro7m5vgpfdcy3pxtpl52hnbgworclnzw && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gro7m5vgpfdcy3pxtpl52hnbgworclnzw && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.