Skip to content

[kani] Strengthen DST layout proofs - #3661

Open
joshlf wants to merge 1 commit into
Gfdfm7an47cyz2scdlmc6lpej7h2q5qlxfrom
G44fd7b86a51e9f6cabdcddc13cebc2f0
Open

[kani] Strengthen DST layout proofs#3661
joshlf wants to merge 1 commit into
Gfdfm7an47cyz2scdlmc6lpej7h2q5qlxfrom
G44fd7b86a51e9f6cabdcddc13cebc2f0

Conversation

@joshlf

@joshlf joshlf commented Sep 9, 2026

Copy link
Copy Markdown
Member

Refactor the DstLayout harnesses around independent standard-library Layout oracles, explicit proof domains, and non-vacuity covers. Add a fail-closed Kani runner which rejects missing or unsatisfied cover summaries.

Authored by an AI agent acting on Josh Liebow-Feeser's behalf.


Latest Update: v10 — Compare vs v9

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/G44fd7b86a51e9f6cabdcddc13cebc2f0 && git checkout -b pr-G44fd7b86a51e9f6cabdcddc13cebc2f0 FETCH_HEAD

Checkout

git fetch origin refs/heads/G44fd7b86a51e9f6cabdcddc13cebc2f0 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/G44fd7b86a51e9f6cabdcddc13cebc2f0 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/G44fd7b86a51e9f6cabdcddc13cebc2f0

Stacked PRs enabled by GHerrit.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-09-09T17:20:45.359904Z 6843138 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov-commenter

codecov-commenter commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.86%. Comparing base (71b2944) to head (757a961).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           Gfdfm7an47cyz2scdlmc6lpej7h2q5qlx    #3661   +/-   ##
==================================================================
  Coverage                              91.86%   91.86%           
==================================================================
  Files                                     20       20           
  Lines                                   6097     6097           
==================================================================
  Hits                                    5601     5601           
  Misses                                   496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf

joshlf commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@codex review

Please review current head a0a14a5a8ced4604cc48ad08127b7aa9e2fa920d; in particular, challenge the documented proof domain and exclusions, and verify that expected behavior comes from an independent safe Rust, standard-library, language, or explicitly labeled policy oracle.

Authored by an AI agent acting on Josh Liebow-Feeser's behalf.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: a0a14a5a8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf
joshlf force-pushed the G44fd7b86a51e9f6cabdcddc13cebc2f0 branch from a0a14a5 to e7ef4f3 Compare September 9, 2026 01:53
@joshlf joshlf changed the title [kani] Strengthen existing layout proofs [kani] Strengthen DST layout proofs Sep 9, 2026
@joshlf

joshlf commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@codex review

Authored by an AI agent acting on Josh Liebow-Feeser's behalf.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: e7ef4f3261

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf

joshlf commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@codex review

Please review exact head e7ef4f32615d012e3d1753675ba2adcf0ead6b26.

Authored by an AI agent acting on Josh Liebow-Feeser's behalf.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: e7ef4f3261

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf
joshlf force-pushed the G44fd7b86a51e9f6cabdcddc13cebc2f0 branch from e7ef4f3 to 757a961 Compare September 9, 2026 04:12
@joshlf
joshlf force-pushed the Gfdfm7an47cyz2scdlmc6lpej7h2q5qlx branch from 1cc864b to 71b2944 Compare September 9, 2026 04:12
@joshlf

joshlf commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

Authored by an AI agent acting on Josh Liebow-Feeser's behalf.

@codex review

Exact-head review request: 757a961

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 757a9611c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Refactor the DstLayout harnesses around independent standard-library Layout oracles, explicit proof domains, and non-vacuity covers. Add a fail-closed Kani runner which rejects missing or unsatisfied cover summaries.

*Authored by an AI agent acting on Josh Liebow-Feeser's behalf.*

gherrit-pr-id: G44fd7b86a51e9f6cabdcddc13cebc2f0
@joshlf
joshlf force-pushed the Gfdfm7an47cyz2scdlmc6lpej7h2q5qlx branch from 71b2944 to d773c6c Compare September 9, 2026 17:18
@joshlf
joshlf force-pushed the G44fd7b86a51e9f6cabdcddc13cebc2f0 branch from 757a961 to 6843138 Compare September 9, 2026 17:18
@joshlf

joshlf commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

Authored by an AI agent acting on Josh Liebow-Feeser's behalf.

@codex review

Exact-head review request: 6843138

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Provided git ref 68431383709eb0801b2fcb803bd6200ffc6af94d does not exist
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants