chore: Error handling when upload id I'd incorrect for Resumable upload - #24234
chore: Error handling when upload id I'd incorrect for Resumable upload#24234shubhangi-google wants to merge 6 commits into
Conversation
|
Please fix the title: looks like there are some typos |
| if response.status.to_i == 404 | ||
| logger.debug { sprintf("Failed to fetch upload session. Response: #{response.status.to_i} - #{response.body}") } | ||
| false | ||
| end |
There was a problem hiding this comment.
The call to check the upload ID's status failed with a 404 error. That status code means the upload ID is not recognized by the server, so the process is stopping and returning false.
There was a problem hiding this comment.
Could you also add tests for success cases.
There was a problem hiding this comment.
success test cases were added and have been merged already here
|
@shubhangi-google PLMK if you still want to get this change in. I can take a look for you |
|
@shubhangi-google can we revisit this please? Either close it or merge as needed (please rebase and I can help you with an approval). |
the code change is being considered as breaking change hence closing the PR for now will be reopening it when required |
4 participants
Updated code to explicitly handle 404 (Not Found) responses, ensuring that operations correctly fail when an upload session ID is invalid.
Error handling done for code implemented in - #21896, #23376
Implementation linked with- googleapis/google-cloud-ruby#30882