chore(storage): remove form-data dependency use native globals and update package scripts - #9120
chore(storage): remove form-data dependency use native globals and update package scripts#9120thiyaguk09 wants to merge 17 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the 'samples-test' script, cleans up unused dependencies ('form-data' and 'cross-env'), and simplifies the 'test' script. Feedback suggests replacing the 'samples-test' script with a no-op command instead of deleting it to avoid breaking CI pipelines that might still invoke it. Additionally, it is recommended to restore the 'cross-env' and preload configuration in the 'test' script, as removing them appears unrelated to the dependency cleanup.
ad286ae to
666d700
Compare
…pes/request dependency
666d700 to
033de68
Compare
This was addressed here: 033de68. However, the version bump was completed and released in a separate PR prior to this merge, which is why it is not reflected here. |
Can we update the pr description of this pr to reflect the changes accordingly ? |
The description has been updated accordingly. |
Removes the
form-datadependency (and related legacy HTTP packages) in@google-cloud/storageby adopting native Node.js 18+ global APIs and resolving transitive vulnerability paths.Key Changes
form-dataandnode-fetchimports in tests with built-in globalFormDataandfetch.form-data,node-fetch,@types/node-fetchfromdevDependencies.@types/requestto ^2.48.12.Fixes #7348