Skip to content

chore: onboarding Gems with additional_protos - #36515

Open
suztomo wants to merge 2 commits into
googleapis:mainfrom
suztomo:chore/onboarding-google-identity-access_context_manager-v1
Open

chore: onboarding Gems with additional_protos#36515
suztomo wants to merge 2 commits into
googleapis:mainfrom
suztomo:chore/onboarding-google-identity-access_context_manager-v1

Conversation

@suztomo

@suztomo suztomo commented Sep 2, 2026

Copy link
Copy Markdown
Member

See go/sdk-librarian-ruby-tracker and googleapis/librarian#7380.

Onboarded Libraries

  • google-identity-access_context_manager-v1 (v0.15.1)
  • google-cloud-gke_hub-v1 (v2.6.1)
  • google-cloud-os_login-v1 (v1.7.1)
  • google-cloud-os_login-v1beta (v0.22.1)

Configuration Changes

Added additional_protos under ruby and removed skip_generate: true in librarian.yaml for:

  • google-identity-access_context_manager-v1:
    • google/identity/accesscontextmanager/type/device_resources.proto
  • google-cloud-gke_hub-v1:
    • google/cloud/gkehub/v1/configmanagement/configmanagement.proto
    • google/cloud/gkehub/v1/multiclusteringress/multiclusteringress.proto
    • google/cloud/gkehub/v1/rbacrolebindingactuation/rbacrolebindingactuation.proto
  • google-cloud-os_login-v1:
    • google/cloud/oslogin/common/common.proto
  • google-cloud-os_login-v1beta:
    • google/cloud/oslogin/common/common.proto

Diff Findings & Categorization

Standard Expected Changes

  1. OwlBot Removal: Removed .OwlBot.yaml and .owlbot-manifest.json from all onboarded gems.
  2. Library Metadata / Description: Synchronized description in README.md and .gemspec with service config yaml.
  3. Copyright Year: Updated to 2026.
  4. Snippet File Permissions: Corrected snippet script permissions from 755 to 644.
  5. Additional Protos Preservation: Subpackage protobuf files (*_pb.rb) and proto documentation were cleanly generated and retained.

Local Verification

Passed toys ci --test --rubocop --doctest --gems google-identity-access_context_manager-v1,google-cloud-gke_hub-v1,google-cloud-os_login-v1,google-cloud-os_login-v1beta:

  • google-cloud-gke_hub-v1: 106 runs, 3017 assertions, 0 failures, 0 errors, 0 skips; 59 files inspected, 0 offenses
  • google-identity-access_context_manager-v1: 67 runs, 1816 assertions, 0 failures, 0 errors, 0 skips; 41 files inspected, 0 offenses
  • google-cloud-os_login-v1beta: 22 runs, 480 assertions, 0 failures, 0 errors, 0 skips; 21 files inspected, 0 offenses
  • google-cloud-os_login-v1: 20 runs, 413 assertions, 0 failures, 0 errors, 0 skips; 20 files inspected, 0 offenses

@suztomo
suztomo marked this pull request as ready for review September 2, 2026 17:45
@suztomo
suztomo requested review from a team and yoshi-approver as code owners September 2, 2026 17:45
@suztomo

suztomo commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

This is ready for review.

@suztomo
suztomo marked this pull request as draft September 2, 2026 18:18
@suztomo

suztomo commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

I'm adding more Gems.

@suztomo
suztomo force-pushed the chore/onboarding-google-identity-access_context_manager-v1 branch from 741bd53 to 0ecb882 Compare September 2, 2026 18:20
@suztomo suztomo changed the title fix: onboarding google-identity-access_context_manager-v1 to Librarian chore: onboarding Gems with additional_protos Sep 2, 2026
@suztomo
suztomo marked this pull request as ready for review September 2, 2026 18:31
@suztomo

suztomo commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

It's ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants