chore: sync skills with Discovery API - #887
Conversation
🦋 Changeset detectedLatest commit: b67cee5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the generated skill documentation to align with the latest Google Discovery API specifications. The changes include adding new API methods to the documentation, clarifying existing parameter behaviors, and providing better guidance for service-specific operations to ensure the CLI documentation remains accurate and helpful for users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request syncs generated skills with the latest Google Discovery API specifications, updating the documentation (SKILL.md files) for Calendar, Chat, Classroom, Drive, Gmail, and Sheets Append. The review feedback highlights a formatting issue in the newly added Calendar transferOwnership documentation, where the authorization scopes list is broken and needs proper indentation.
| - https://www.googleapis.com/auth/calendar | ||
| - https://www.googleapis.com/auth/calendar.calendars In the request, set useAdminAccess to true. The secondary calendar must be active to be transferred. Transferring disabled or deleted calendars isn't supported. |
There was a problem hiding this comment.
The formatting for this list of authorization scopes is broken, making it hard to read. The scopes should be properly indented as a sub-list, and the subsequent text should be separated for clarity.
| - https://www.googleapis.com/auth/calendar | |
| - https://www.googleapis.com/auth/calendar.calendars In the request, set useAdminAccess to true. The secondary calendar must be active to be transferred. Transferring disabled or deleted calendars isn't supported. | |
| - `https://www.googleapis.com/auth/calendar` | |
| - `https://www.googleapis.com/auth/calendar.calendars` | |
| In the request, set `useAdminAccess` to `true`. The secondary calendar must be active to be transferred. Transferring disabled or deleted calendars isn't supported. |
d35c61e to
79ac920
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the generated skills documentation across several Google Workspace services—including Calendar, Chat, Classroom, Drive, Gmail, and Sheets—to align with the latest Google Discovery API specifications. The feedback identifies a markdown formatting issue in the Calendar skill documentation, where incorrect indentation of the authorization scopes for the transferOwnership method would prevent proper rendering.
| - https://www.googleapis.com/auth/calendar | ||
| - https://www.googleapis.com/auth/calendar.calendars In the request, set useAdminAccess to true. The secondary calendar must be active to be transferred. Transferring disabled or deleted calendars isn't supported. |
There was a problem hiding this comment.
The formatting for the list of authorization scopes is incorrect. The list items are not indented, so they will be rendered as top-level list items instead of a nested list under the transferOwnership method. This makes the documentation confusing and hard to read. Additionally, the note about useAdminAccess is on the same line as a scope, which further harms readability.
| - https://www.googleapis.com/auth/calendar | |
| - https://www.googleapis.com/auth/calendar.calendars In the request, set useAdminAccess to true. The secondary calendar must be active to be transferred. Transferring disabled or deleted calendars isn't supported. | |
| - https://www.googleapis.com/auth/calendar | |
| - https://www.googleapis.com/auth/calendar.calendars | |
| In the request, set useAdminAccess to true. The secondary calendar must be active to be transferred. Transferring disabled or deleted calendars isn't supported. |
b07d984 to
7d50b21
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the generated skill documentation files across several Google Workspace services (Calendar, Chat, Classroom, Drive, Gmail, and Sheets) to sync them with the latest Google Discovery API specifications. Feedback points out a formatting issue in the generated Markdown for the Calendar skill, where unindented URLs break the list structure. This issue should be addressed in the generator script to ensure multi-line descriptions are properly indented.
| - `transferOwnership` — Transfers a secondary calendar between users within a Google Workspace organization. Requires user authentication with Manage Calendars administrator privilege, and one of the following authorization scopes: | ||
| - https://www.googleapis.com/auth/calendar | ||
| - https://www.googleapis.com/auth/calendar.calendars In the request, set useAdminAccess to true. The secondary calendar must be active to be transferred. Transferring disabled or deleted calendars isn't supported. |
There was a problem hiding this comment.
The list formatting for the transferOwnership method is broken because the scope URLs are not indented. In Markdown, nested list items must be indented (typically with 4 spaces) to be rendered correctly as a sub-list. Otherwise, they break the outer list structure.
Since this is an automated PR generated by generate-skills.yml, the root cause is in the generator script (crates/google-workspace-cli/src/generate_skills.rs). The generator should be updated to properly indent multi-line descriptions fetched from the Google Discovery API. Specifically, any newlines in the description should be prefixed with appropriate indentation (e.g., 4 spaces) to preserve the list hierarchy in the generated SKILL.md files.
7d50b21 to
937d833
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the generated Google Workspace skill definitions to sync with the latest Google Discovery API specifications. Key changes include adding new methods such as transferOwnership in Calendar, findGroupChats in Chat, and several approval-related methods in Drive, as well as updating various method descriptions and clarifying flag behaviors in Sheets. I have no feedback to provide as there are no review comments.
b4b7781 to
75a8bd7
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request syncs the generated Google Workspace skills with the latest Google Discovery API specifications, updating several markdown skill files for Calendar, Chat, Classroom, Drive, Gmail, and Sheets. The feedback points out a formatting issue in skills/gws-calendar/SKILL.md where unindented newlines and bullet points for the transferOwnership method break the markdown list nesting, and provides a suggestion to correct it.
| - `transferOwnership` — Transfers a secondary calendar between users within a Google Workspace organization. Requires user authentication with Manage Calendars administrator privilege, and one of the following authorization scopes: | ||
| - https://www.googleapis.com/auth/calendar | ||
| - https://www.googleapis.com/auth/calendar.calendars In the request, set useAdminAccess to true. The secondary calendar must be active to be transferred. Transferring disabled or deleted calendars isn't supported. |
There was a problem hiding this comment.
The description for transferOwnership contains unindented newlines and bullet points, which breaks the markdown list nesting. This causes the scopes and the subsequent description text to be rendered incorrectly, merging them into a single malformed list item. This can confuse LLMs or agents parsing this skill file.
While this file is auto-generated, please update the generator logic in crates/google-workspace-cli/src/generate_skills.rs to properly sanitize or indent multi-line descriptions from the Discovery API. In the meantime, here is the corrected formatting for this file.
| - `transferOwnership` — Transfers a secondary calendar between users within a Google Workspace organization. Requires user authentication with Manage Calendars administrator privilege, and one of the following authorization scopes: | |
| - https://www.googleapis.com/auth/calendar | |
| - https://www.googleapis.com/auth/calendar.calendars In the request, set useAdminAccess to true. The secondary calendar must be active to be transferred. Transferring disabled or deleted calendars isn't supported. | |
| - `transferOwnership` — Transfers a secondary calendar between users within a Google Workspace organization. Requires user authentication with Manage Calendars administrator privilege, and one of the following authorization scopes: | |
| - https://www.googleapis.com/auth/calendar | |
| - https://www.googleapis.com/auth/calendar.calendars | |
| In the request, set useAdminAccess to true. The secondary calendar must be active to be transferred. Transferring disabled or deleted calendars isn't supported. |
75a8bd7 to
b67cee5
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for several Google Workspace CLI skills to sync them with the latest Google Discovery API specifications. Key changes include adding documentation for new methods such as transferOwnership in Calendar, findGroupChats and availability in Chat, several approval-related methods and generateCseToken in Drive, as well as updating descriptions for existing methods and flags in Classroom, Gmail, and Sheets-append. There are no review comments, so I have no feedback to provide.
Automated PR — the Google Discovery API specs have changed and the
generated skill files are out of date.
Created by the Generate Skills workflow (
generate-skills.yml).