Align sun/moon icon in theme toggle with navbar items - #212
Open
delize wants to merge 24 commits into
Open
Conversation
CeduDev
reviewed
Apr 7, 2025
Comment on lines
13
to
17
| header .navbar .navbar-nav a { | ||
| color: var(--text-color) !important; | ||
| display: flex; | ||
| align-items: center; /* Vertically align all items */ | ||
| } |
Contributor
There was a problem hiding this comment.
I like this fix, definitely bothered me as well. However, with this implementation on mobile, the hamburger menu items are all aligned to the left (they were aligned to the center before). Personally, I like that aligned more, which thus would require this change
Suggested change
| header .navbar .navbar-nav a { | |
| color: var(--text-color) !important; | |
| display: flex; | |
| align-items: center; /* Vertically align all items */ | |
| } | |
| header .navbar .navbar-nav a, | |
| header .navbar .navbar-nav div { | |
| color: var(--text-color) !important; | |
| display: flex; | |
| align-items: center; /* Vertically align all items */ | |
| justify-content: center /* Horizontally align all items */; | |
| } |
This ofc is up to @gurusabarish, however they see fit
Contributor
Author
There was a problem hiding this comment.
Hey, not opposed to implementing this in the PR. Originally I only checked how this looked on Desktop, not mobile, but noticed it several weeks after the PR. I just was okay to live with it. When I'm back at a computer I'll see about trying to incorporate that change in to the PR.
gurusabarish
reviewed
Oct 6, 2025
gurusabarish
reviewed
Oct 6, 2025
Fix broken anchor links
- Reorganized and rewrote README to improve flow and clarity for beginners - Fixed broken `x` shortcode by replacing it with `tweet` Note: Twitter embed may fail due to TLS handshake timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to align the theme toggle selector with the rest of the navbar items, for a more professional look.
For example:
https://hugo-profile.netlify.app/
To:
Widescreen
Mobile / iPad
Nothing wrong with the current implementation, but the off-set theme toggle really bothers me UI / UX wise.