Initialize semaphore with braces in NimBLEUtils

[doudar]

Fixes a connect crash in the client

Summary by CodeRabbit

• Refactor
  • Improved initialization of internal semaphore objects without changing observable application behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 89611ecf-ace8-4931-b2ef-41da3e1adead

📥 Commits

Reviewing files that changed from the base of the PR and between 782af27 and 9fae15e.

📒 Files selected for processing (1)

• src/NimBLEUtils.cpp

---

📝 Walkthrough

Walkthrough

Arrr, taskWait now value-initializes newly allocated semaphore objects. The remaining semaphore setup, error handling, storage, and wait flow remain unchanged.

Changes

Semaphore initialization

Layer / File(s)	Summary
Update semaphore allocation src/NimBLEUtils.cpp	taskWait uses brace initialization for newly allocated semaphore objects. Subsequent initialization and waiting logic remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• h2zero/esp-nimble-cpp#421: Arrr, this PR previously refactored NimBLEUtils.cpp::taskWait to allocate and wait on tracked semaphores.

Poem

A brace sets sail, arrr,
The semaphore wakes whole,
taskWait keeps its course,
No runtime waves arise,
The code rests shipshape.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the semaphore initialization change in NimBLEUtils.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[h2zero]

LGTM thanks!