feat: relocate vite concerns from esbuild-plugin to vite-plugin - #4633
Merged
Conversation
GordonSmith
force-pushed
the
VITE_REFACTOR
branch
2 times, most recently
from
August 19, 2026 12:07
897db3e to
6387ff1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }); | ||
| const expr = build(payload.expr); | ||
| lines.push( | ||
| `export const __dojoEvaluate = () => ${expr};`, |
| payload.deps.forEach((dep, i) => { | ||
| const absMid = dep.split("!").map(part => resolver.toAbsMid(part, payload.reference)).join("!"); | ||
| lines.push(`import __d${i} from ${JSON.stringify(dep)};`); | ||
| entries.push(`${JSON.stringify(absMid)}: __dojoDep(() => __d${i}, ${JSON.stringify(absMid)})`); |
| const entries: string[] = []; | ||
| deps.forEach((dep, i) => { | ||
| lines.push(`import __d${i} from ${JSON.stringify(dep)};`); | ||
| entries.push(`${JSON.stringify(dep)}: __dojoDep(() => __d${i}, ${JSON.stringify(dep)})`); |
| const requested = resolver.toAbsMid(mid, reference); | ||
| noteAlias(canonicalOf(resolved.id), requested); | ||
| const unwrapDefault = needsInterop && options.esmInterop !== "namespace"; | ||
| return `__dojoRt.__dojoDep(() => ${name}, ${JSON.stringify(requested)}${unwrapDefault ? ", 1" : ""})`; |
| noteAlias(canonicalOf(resolved.id), requested); | ||
| const isRuntimeHas = resolved.id.startsWith(PREFIX + "has:"); | ||
| target.push( | ||
| `${JSON.stringify(mid)}: {load: () => import(${JSON.stringify(resolved.id)}), absMid: ${JSON.stringify(requested)}${isRuntimeHas ? ", runtimeHas: true" : ""}}` |
| noteAlias(canonicalOf(resolved.id), requested); | ||
| const isRuntimeHas = resolved.id.startsWith(PREFIX + "has:"); | ||
| target.push( | ||
| `${JSON.stringify(mid)}: {load: () => import(${JSON.stringify(resolved.id)}), absMid: ${JSON.stringify(requested)}${isRuntimeHas ? ", runtimeHas: true" : ""}}` |
GordonSmith
force-pushed
the
VITE_REFACTOR
branch
2 times, most recently
from
August 19, 2026 12:20
ef59b94 to
226483c
Compare
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
force-pushed
the
VITE_REFACTOR
branch
from
August 19, 2026 12:27
226483c to
7c714f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: