Pin prediction cache to resolved model revisions - #1369
Open
LarryHu0217 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Include the immutable Hub revision already resolved by the Transformers and VLM backends in the prediction cache identity.
This prevents a mutable revision such as
mainfrom reusing predictions generated by older model weights. Backends that do not expose an immutable identity retain their existing cache hashes.The caching documentation now also explains the remaining limitation for local model directories and opaque endpoints whose weights are replaced in place.
Addresses #1364
Testing
The full cache module was also attempted locally. Tests requiring the optional vLLM and torchvision backends could not run because those dependencies are not installed.