perf: cache API sandbox profile lookups - #57
Merged
Conversation
Cache the profile values once instead of allocating a new array for each profile lookup during API sandbox processing. Preserve the existing lookup behavior while avoiding repeated Object.values calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API_SANDBOX_PROFILESonce at module initialization.getApiSandboxProfileandgetProfileById.Why
The API Sandpack processing path repeatedly called
Object.values(API_SANDBOX_PROFILES), allocating a new array for every profile lookup. The profile set is static, so caching the values avoids unnecessary allocations while keeping the code straightforward.Scope
This PR contains only the source change described above. It does not add tests or alter generated documentation.
Validation
node --check scripts/api-sandpack-examples.mjsnode scripts/api-sandpack-examples.mjs --check./node_modules/.bin/vitepress buildgit diff --checkThe API Sandpack check reported 0 transformed files and 661 live examples across 757 scanned files. The VitePress build completed successfully. The build also reported the existing environment warning that the editor sketch loader could not fetch
api.github.com.