Conversation
Changes: - Fix CID 8502504 (TOCTOU): Ensure safe buffer size and explicit null-termination on readlink in MediaControl::getDevnameFromSysfs - Fix CID 8504454 (UNINIT): Initialize tagType to -1 in CameraSensorsParser::parseGenericStaticMetaData Change-Id: Icb55fb8ebc8e0696aaf91fc4bed14102c1e513c7 Tracked-On: #JSWBALINUX-258 Signed-off-by: Amarnath Kumar, Deepak <deepak.amarnath.kumar@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves two static analysis defects identified in Coverity scans:
CID 8502504 (TOCTOU / Buffer Hardening in
MediaControl):readlinkinMediaControl::getDevnameFromSysfsusessizeof(target) - 1and explicitly null-terminates attarget[ret].CID 8504454 (UNINIT in
CameraSensorsParser):int tagType = -1;inCameraSensorsParser::parseGenericStaticMetaDatato avoid uninitialized scalar reads.Reference