Skip to content

Login refactor - brought back recent changes - #2767

Merged
trtshen merged 19 commits into
login-refactorfrom
login-refactor-chaw-pr
Sep 11, 2026
Merged

trtshen merged 19 commits into
login-refactorfrom
login-refactor-chaw-pr

Conversation

@trtshen

@trtshen trtshen commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

This pull request updates accessibility documentation and assessment flow documentation to clarify and improve descriptions of WCAG compliance, Team360 assessment pagination, and message attachment preview behavior. It also adds new documentation for a recent fix and updates changelogs and feature documentation for clarity and accuracy.

Accessibility Documentation Improvements:

  • Added checklist items and retest instructions to ensure the accessWidget trigger does not obscure chat controls at any viewport size, and clarified the files involved in fixing focus-obscured issues (global.scss, styles.scss, index.html). [1] [2] [3]

Assessment Pagination and Team360 Flow Clarifications:

  • Updated assessment flow and feature toggle documentation to clarify Team360 pagination: each configured group now renders on its own page, selector-free groups can appear anywhere, and navigation skips unused placeholder pages. Submission requirements and completion logic for Team360 are now described in more detail, including the distinction between peer and non-peer groups and stricter submission guards. [1] [2] [3] [4] [5] [6]

  • Documented new UI logic for assessment/review submit buttons, including a distinct loading state, proper ARIA attributes, and clear separation between validation and loading disables.

  • Clarified display logic for reviewer-only multiple/oneof questions, ensuring all choices are shown with clear statuses in both feedback and review-complete modes. [1] [2]

Documentation and Changelog Updates:

  • Added a new fix documentation page for "CORE-8316 Immediate Message Attachment Preview," describing the real-time contract for chat attachments, preview logic, and verification steps.
  • Updated the main documentation changelog to include the new fix and a profile picture upload fix.
  • Updated review dates in assessment flow and feature toggle documentation for accuracy. [1] [2]

Minor Styling Clarification:

  • Added a comment clarifying that .label styling in the slider rating implementation uses shared sizing and typography.**

trtshen added 19 commits August 13, 2026 16:24
…ification-loginrefactor' into login-refactor-chaw-pr
(cherry picked from commit 5f0c7b5)
(cherry picked from commit 08a4dc5)
(cherry picked from commit f6c4c7a)
(cherry picked from commit 1ac119c)
(cherry picked from commit 4d07f45)
(cherry picked from commit 3c4f098)
@trtshen

trtshen commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author
Screenshot 2026-09-11 at 9 04 17 AM

Note: The failing CI check error is caused by gitleaks/gitleaks-action@v2 require a GITLEAKS_LICENSE secret for organization-owned repositories.

@trtshen
trtshen merged commit 3b6e3d8 into login-refactor Sep 11, 2026
1 check failed
@trtshen
trtshen deleted the login-refactor-chaw-pr branch September 11, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants