fix(ios): link FirebaseCore into Expo app target under SPM - #9211
Draft
russellwheatley wants to merge 2 commits into
Draft
fix(ios): link FirebaseCore into Expo app target under SPM#9211russellwheatley wants to merge 2 commits into
russellwheatley wants to merge 2 commits into
Conversation
Expo documented path (SPM on, dynamic frameworks) still fails iOS link with missing app-target FirebaseCore after #9164. Land the red closer before chasing duplicate-symbol work.
Expo prebuild --clean has no [CP] Embed Pods Frameworks until integrate_user_project. Running the app-target helper from post_integrate lets FIRApp resolve on the documented dynamic path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9158.
Expo
prebuild --cleanstill failed iOS link with undefined_OBJC_CLASS_$_FIRAppafter #9164. The app-target helper ran in CocoaPodspost_install, beforeintegrate_user_projectadds[CP] Embed Pods Frameworks, so every native target was skipped.yarn test-expo:ios:linkas a red closer for that signaturepost_integrateso FirebaseCore actually links into the Expo app target