Skip config loading for Configurables with no matching config - #969
Merged
Conversation
Configurable._load_config computed traits(config=True) and entered hold_trait_notifications() unconditionally, even for the many leaf Configurables in an Application graph whose config has no keys matching the instance. It now computes my_config first and returns early when it is empty, before doing any of that work. Also removes a dead `section_names = self.section_names()` local that was computed (section_names() walks the MRO with issubclass checks, twice per instance) but never used — _find_my_config recomputes it internally. The section_names parameter is kept in the signature for backward compatibility.
Codecov Report✅ All modified and coverable lines are covered by tests.
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurable._load_config computed traits(config=True) and entered hold_trait_notifications() unconditionally, even for the many leaf Configurables in an Application graph whose config has no keys matching the instance. It now computes my_config first and returns early when it is empty, before doing any of that work.
Also removes a dead
section_names = self.section_names()local that was computed (section_names() walks the MRO with issubclass checks, twice per instance) but never used — _find_my_config recomputes it internally. The section_names parameter is kept in the signature for backward compatibility.