Skip to content

Remove year from license headers - #376

Merged
hardikdr merged 1 commit into
mainfrom
chore/375-remove-year-license-headers
Sep 9, 2026
Merged

Remove year from license headers#376
hardikdr merged 1 commit into
mainfrom
chore/375-remove-year-license-headers

Conversation

@friegger

@friegger friegger commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #375

Summary by CodeRabbit

  • Documentation

    • Standardized SPDX copyright notices across the project.
    • Removed fixed copyright years and aligned attribution with SAP SE, SAP affiliates, and IronCore contributors.
    • Added the standard SPDX header to an end-to-end test file.
  • Chores

    • No functional or user-facing behavior changes.

Signed-off-by: Felix Riegger <felix.riegger@sap.com>
@friegger
friegger requested a review from a team as a code owner September 8, 2026 14:12
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ecc4a3fe-32bd-413f-aba6-61be775f7222

📥 Commits

Reviewing files that changed from the base of the PR and between f0784f3 and 52108ab.

📒 Files selected for processing (40)
  • CLAUDE.md
  • REUSE.toml
  • api/v1alpha1/constants.go
  • api/v1alpha1/doc.go
  • api/v1alpha1/groupversion_info.go
  • api/v1alpha1/httpbootconfig_types.go
  • api/v1alpha1/ipxebootconfig_types.go
  • api/v1alpha1/zz_generated.deepcopy.go
  • cmd/bootctl/app/app.go
  • cmd/bootctl/app/move.go
  • cmd/bootctl/main.go
  • cmd/main.go
  • cmdutils/clients.go
  • cmdutils/move.go
  • cmdutils/move_test.go
  • cmdutils/suite_test.go
  • cmdutils/utils.go
  • hack/boilerplate.go.txt
  • hack/license-header.txt
  • internal/controller/httpbootconfig_controller.go
  • internal/controller/httpbootconfig_controller_test.go
  • internal/controller/ipxebootconfig_controller.go
  • internal/controller/ipxebootconfig_controller_test.go
  • internal/controller/serverbootconfig_helpers_test.go
  • internal/controller/serverbootconfiguration_http_controller.go
  • internal/controller/suite_test.go
  • internal/oci/manifest.go
  • internal/registry/validation.go
  • internal/registry/validation_test.go
  • internal/uki/oci.go
  • internal/uki/oci_test.go
  • server/bootserver.go
  • server/bootserver_suit_test.go
  • server/bootserver_test.go
  • server/helper.go
  • server/imageproxyserver.go
  • test/e2e/e2e_suite_test.go
  • test/e2e/e2e_test.go
  • test/registry/registry.go
  • test/utils/utils.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change removes fixed years from SPDX copyright notices across repository metadata, license templates, production Go files, generated code, tests, and integration files. One test file also receives SPDX copyright and Apache-2.0 license headers.

Changes

License header migration

Layer / File(s) Summary
Header policy and templates
CLAUDE.md, REUSE.toml, hack/*
Documentation, REUSE annotations, and license templates use year-free SPDX copyright text.
Production source headers
api/v1alpha1/*, cmd/*, cmdutils/*.go, internal/*, server/*.go
Production and generated Go files remove fixed years from SPDX copyright headers.
Test and integration headers
cmdutils/*_test.go, internal/**/*_test.go, server/*_test.go, test/*
Test and integration files remove fixed years. internal/uki/oci_test.go receives SPDX and Apache-2.0 headers.

Priority: ⬇️ Low — Defer this license-header cleanup because it is a low-effort, non-functional metadata change with no product behavior impact.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 52108

This change standardizes repository SPDX copyright headers to year-free text while preserving license metadata, with no runtime behavior change or outstanding merge-readiness risk.

Suggested reviewers: hardikdr

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only contains Fixes #375`` and omits the required # Proposed Changes section and change summary. Add the # Proposed Changes section with concise bullets describing the year-free SPDX header migration, then retain Fixes #375``. Ensure the description reflects the required changes and validation.
Linked Issues check ⚠️ Warning The changes address the main objective in [#375] by replacing year-bearing SPDX copyright text across the listed files. The provided changes do not show a safe rewrite process or documentation for upd… Add or document the safe rewrite process required by [#375]. Confirm that all tracked files with existing license headers were updated and that their SPDX license markers remain valid.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing years from license headers.
Out of Scope Changes check ✅ Passed The changes are limited to SPDX copyright header updates and adding a standard SPDX header to a test file. No unrelated functional changes are shown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Full details: Linked Issues check

Explanation

The changes address the main objective in [#375] by replacing year-bearing SPDX copyright text across the listed files. The provided changes do not show a safe rewrite process or documentation for updating existing headers when tooling cannot rewrite them.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/375-remove-year-license-headers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hardikdr
hardikdr merged commit e1eb03a into main Sep 9, 2026
18 checks passed
@hardikdr
hardikdr deleted the chore/375-remove-year-license-headers branch September 9, 2026 07:36
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Remove years from existing license headers

2 participants