Skip to content

Improve tests performance #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nleush wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Improve tests performance #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a520dc2
add important indexes
nleush Aug 20, 2026
2d6d0e7
clean old logs on notification check
nleush Aug 20, 2026
1fe825c
remove old test data
nleush Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions modules/tests-ui/models.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@
return this.errors_list && this.errors_list.length > 0;
};

// Used in `loadPluginTests`, `loadTestSets`, `removeOldSets`.
TestUrlsSetSchema.index({plugin: 1, created_at: -1});

var PageTestLogSchema = new Schema({

url: {
Expand Down Expand Up @@ -151,6 +154,9 @@
return moment(this.created_at).format("DD-MM-YY HH:mm");
};

// Used in `checkPageTestLogChangeNotification`.
PageTestLogSchema.index({plugin: 1, url: 1, created_at: -1});

export const PluginTest = db.model('PluginTest', PluginTestSchema);
export const PageTestLog = db.model('PageTestLog', PageTestLogSchema);
export const TestUrlsSet = db.model('TestUrlsSet', TestUrlsSetSchema);
Expand Down
56 changes: 54 additions & 2 deletions modules/tests-ui/tester.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ var PageTestLog = models.PageTestLog;
var TestUrlsSet = models.TestUrlsSet;
var TestingProgress = models.TestingProgress;

var OLD_LOGS_MONTH_TTL = 30 * 24 * 60 * 60 * 1000;

function log() {
if (CONFIG.DEBUG) {
console.log.apply(console, arguments);
Expand Down Expand Up @@ -134,8 +136,8 @@ function checkPageTestLogChangeNotification(logEntry) {

PageTestLog
.find({
url: logEntry.url,
plugin: logEntry.plugin,
url: logEntry.url,
created_at: {
$lt: logEntry.created_at
}
Expand All @@ -146,6 +148,19 @@ function checkPageTestLogChangeNotification(logEntry) {

previousLogEntry = previousLogEntry && previousLogEntry.length && previousLogEntry[0];

if (previousLogEntry) {
// Keep only current and previous log per plugin+url, older ones are unused.
PageTestLog.deleteMany({
plugin: logEntry.plugin,
url: logEntry.url,
created_at: {
$lt: previousLogEntry.created_at
}
}).catch(function(error) {
cerror('Error removing old page test logs', error);
});
}

/*

Case 1.
Expand Down Expand Up @@ -564,6 +579,24 @@ function processPluginTests(pluginTest, plugin, count, cb) {
cb(null, data);
})
.catch(cb);
},

function removeOldLogs(data, cb) {
// Logs of urls no longer in the current set.
PageTestLog.deleteMany({
plugin: plugin.id,
url: {
$nin: testUrlsSet.urls
},
created_at: {
// Remove only old.
$lt: new Date(new Date() - OLD_LOGS_MONTH_TTL)
}
})
.then(data => {
cb(null, data);
})
.catch(cb);
}

], cb);
Expand Down Expand Up @@ -604,7 +637,26 @@ function testAll(cb) {
], cb);
},

function loadPluginTests(data, cb) {
function cleanupObsoleteData(data, cb) {
PluginTest.find({obsolete: true}).distinct('_id')
.then(obsoleteIds => {
if (obsoleteIds.length === 0) {
return Promise.resolve();
}
// Keep recent data in case plugin comes back soon.
var monthAgo = new Date(new Date() - OLD_LOGS_MONTH_TTL);
return Promise.all([
TestUrlsSet.deleteMany({plugin: {$in: obsoleteIds}, created_at: {$lt: monthAgo}}),
PageTestLog.deleteMany({plugin: {$in: obsoleteIds}, created_at: {$lt: monthAgo}})
]);
})
.then(() => {
cb();
})
.catch(cb);
},

function loadPluginTests(cb) {

if (testOnePlugin) {
PluginTest.find({_id: testOnePlugin})
Expand Down
Loading