pass 'self' by pointer instead of by value in ensureUnusedCapacity().… - #3
Open
wc-duck wants to merge 1 commit into
Open
pass 'self' by pointer instead of by value in ensureUnusedCapacity().…#3wc-duck wants to merge 1 commit into
wc-duck wants to merge 1 commit into
Conversation
… Not doing this can cause exhaustive copying of memory leading to horrible performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Not doing this can cause exhaustive copying of memory leading to horrible performance.
It should be noted here that I'm a real 'zig' beginner so there might be other ways that this should be addressed? But profiling my own application I see that this function takes an exuberant amount of time for what it does.